feat(web): make left column width adjustable by codex#205
Open
yzs981130 wants to merge 2 commits intotiann:mainfrom
Open
feat(web): make left column width adjustable by codex#205yzs981130 wants to merge 2 commits intotiann:mainfrom
yzs981130 wants to merge 2 commits intotiann:mainfrom
Conversation
| setSidebarWidth(clamped) | ||
| if (typeof window !== 'undefined') { | ||
| window.localStorage.setItem(SIDEBAR_WIDTH_STORAGE_KEY, String(clamped)) | ||
| } |
There was a problem hiding this comment.
[MINOR] [PERF] localStorage write on every pointermove
Why this is a problem: pointermove fires at high frequency; localStorage.setItem is synchronous and can block the main thread, making the resize feel janky on lower-end devices. This path runs on every drag tick.
Suggested fix:
const updateSidebarWidth = useCallback((nextWidth: number) => {
const clamped = clampSidebarWidth(nextWidth)
if (sidebarWidthRef.current === clamped) return
sidebarWidthRef.current = clamped
setSidebarWidth(clamped)
}, [clampSidebarWidth])
const persistSidebarWidth = useCallback(() => {
if (typeof window !== 'undefined' && sidebarWidthRef.current != null) {
window.localStorage.setItem(SIDEBAR_WIDTH_STORAGE_KEY, String(sidebarWidthRef.current))
}
}, [])
const handlePointerUp = () => {
persistSidebarWidth()
setIsDraggingSidebar(false)
}There was a problem hiding this comment.
Findings
- [Minor] Synchronous
localStorage.setItemon everypointermovemay cause resize jank; consider persisting on pointerup or debouncingweb/src/router.tsx:129
Summary
- 1 minor perf issue. Residual risk: drag feels sluggish on low-end devices if left as-is.
Testing
- Not run (automation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
sidebarWidth,sidebarWidthRef,isDraggingSidebar) to manage size.updateSidebarWidthhelper and used it for pointer drag and resize-reclamp actions.Codex Task