Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more friendly reply for /lgtm and /merge by contributor without … #538

Merged
merged 2 commits into from
May 13, 2021

Conversation

tisonkun
Copy link
Contributor

…reviewer or committer bit

Signed-off-by: tison wander4096@gmail.com

This closes #535

…reviewer or committer bit

Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. contribution This PR is from a community contributor. labels May 13, 2021
@ti-chi-bot ti-chi-bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2021
@ti-chi-bot
Copy link
Member

Hi @tisonkun. Thanks for your PR.

I'm waiting for a ti-community-infra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented May 13, 2021

🎊 PR Preview 6feba2b has been successfully built and deployed to https://ti-community-infra-tichi-preview-pr-538.surge.sh

🕐 Build time: 0.012s

🤖 By surge-preview

@ti-chi-bot ti-chi-bot added dco-signoff: no Indicates the PR's author has not signed dco. and removed dco-signoff: yes Indicates the PR's author has signed the dco. labels May 13, 2021
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels May 13, 2021
@tisonkun
Copy link
Contributor Author

/release-note-none

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 13, 2021
Copy link
Contributor

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Thanks!

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. status/LGT1 Indicates that a PR has LGTM 1. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #538 (6feba2b) into master (1fcf409) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
+ Coverage   79.51%   79.55%   +0.04%     
==========================================
  Files          16       16              
  Lines        1972     1976       +4     
==========================================
+ Hits         1568     1572       +4     
  Misses        263      263              
  Partials      141      141              
Impacted Files Coverage Δ
internal/pkg/externalplugins/lgtm/lgtm.go 82.55% <100.00%> (+0.13%) ⬆️
internal/pkg/externalplugins/merge/merge.go 82.22% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fcf409...6feba2b. Read the comment docs.

@Rustin170506
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6feba2b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2021
@ti-chi-bot ti-chi-bot merged commit b79eb01 into ti-community-infra:master May 13, 2021
@tisonkun tisonkun deleted the friendly-reply branch May 13, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More friendly reply when a review does not belong to a reviewer or committer
3 participants