New-TssSecretTemplateField - convert Type param to enum

thycotic-ps · Oct 27, 2021 · ac17a5f · ac17a5f
1 parent 8849345
commit ac17a5f
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/docs/commands/secret-templates/New-TssSecretTemplateField.md b/docs/commands/secret-templates/New-TssSecretTemplateField.md
@@ -6,7 +6,7 @@ Create a new field object for the TssSecretTemplate object
 ## SYNTAX
 
 ```
-New-TssSecretTemplateField [-FieldName] <String> [-Type <String>] [-EditRequire <String>]
+New-TssSecretTemplateField [-FieldName] <String> [-Type <TemplateFieldTypes>] [-EditRequire <String>]
  [-Description <String>] [-IsRequired] [-ViewRequiresEdit] [-HistoryLength <Int32>] [-Searchable]
  [-ExposeForDisplay] [-SortOrder <Int32>] [<CommonParameters>]
 ```
@@ -70,9 +70,10 @@ Accept wildcard characters: False
 Field Type: Notes, Text, File, Url, or Password
 
 ```yaml
-Type: String
+Type: TemplateFieldTypes
 Parameter Sets: (All)
 Aliases:
+Accepted values: Notes, Text, File, Url, Password
 
 Required: False
 Position: Named

diff --git a/src/Thycotic.SecretServer/enums/secret-templates/TemplateFieldTypes.cs b/src/Thycotic.SecretServer/enums/secret-templates/TemplateFieldTypes.cs
@@ -0,0 +1,16 @@
+using System;
+using System.Threading.Tasks;
+using System.Management.Automation;
+using System.Management.Automation.Runspaces;
+
+namespace Thycotic.PowerShell.Enums
+{
+    public enum TemplateFieldTypes
+    {
+        Notes,
+        Text,
+        File,
+        Url,
+        Password
+    }
+}
diff --git a/src/functions/secret-templates/New-TssSecretTemplateField.ps1 b/src/functions/secret-templates/New-TssSecretTemplateField.ps1
@@ -52,8 +52,7 @@ function New-TssSecretTemplateField {
         $FieldName,
 
         # Field Type: Notes, Text, File, Url, or Password
-        [ValidateSet('Notes', 'Text', 'File', 'Url', 'Password')]
-        [string]
+        [Thycotic.PowerShell.Enums.TemplateFieldTypes]
         $Type = 'Text',
 
         # Edit permission: Owner, Edit, NotEditable
@@ -96,7 +95,7 @@ function New-TssSecretTemplateField {
             'Edit' { $editablePermission = 2 }
             'NotEditable' { $editablePermission = -1 }
         }
-        switch ($Type) {
+        switch ([string]$Type) {
             'Text' {
                 $isUrl = $isPassword = $isNotes = $isFile = $false
             }