Properly support DATABASE_URL #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched out the code for loading configuration for Rails's version of loading database configuration. Rails has implemented support for DATABASE_URL in rails/rails@13463 and has dealt with the possible combinations of having DATABASE_URL set and a YAML config file, see rails/rails#13463 (comment). There is a breaking change in the way the hash is loaded; Rails does not convert the keys of the hash to symbols, instead they are left as strings; any code reliant on the hash keys being symbols will break.
|
This fixes #111. |
twobitlabs
added a commit
that referenced
this pull request
Apr 14, 2015
Properly support DATABASE_URL
|
Thanks for the pull request, published 4.0.2 of the gem with this included. |
|
thanks @twobitlabs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched out the code for loading configuration for Rails's version of
loading database configuration.
Rails has implemented support for DATABASE_URL in rails/rails#13463 and
has dealt with the possible combinations of having DATABASE_URL set and
a YAML config file, see rails/rails#13463 (comment).
There is a breaking change in the way the hash is loaded; Rails does not
convert the keys of the hash to symbols, instead they are left as
strings; any code reliant on the hash keys being symbols will break.