Add Client-Side Pre-Upload Package Validation

[x753]

Prevents users from attempting to upload packages that aren't zips or packages without a manifest, icon, and readme in the root of the zip.

Warns the user when uploading packages with > 8 DLL files, an Assembly-CSharp.dll file, or BepInEx.dll.

Fixes a chromium bug preventing the selection of a file that was previously selected and canceled.

[Roffenlund]

I cannot build this branch on my machine, it fails with the error [TypeScript error: /app/src/uploadZipValidation.ts(2,39): Error TS2306: File '/app/src/vendor/zip-fs-full.d.ts' is not a module.].

Would adding something like this to the uploadZipValidation.ts solve this instead of trying to import the file?

const zip = require('./vendor/zip-fs-full.js');

const BlobReader = zip.BlobReader;
const ZipReader = zip.ZipReader;

[x753]

I cannot build this branch on my machine, it fails with the error [TypeScript error: /app/src/uploadZipValidation.ts(2,39): Error TS2306: File '/app/src/vendor/zip-fs-full.d.ts' is not a module.].

Would adding something like this to the uploadZipValidation.ts solve this instead of trying to import the file?

const zip = require('./vendor/zip-fs-full.js');

const BlobReader = zip.BlobReader;
const ZipReader = zip.ZipReader;

As of 15c1243 it should build for you now. if your Builder-1 dies, just:

docker compose down
docker volume rm <built-static>
docker compose up builder
docker compose down
docker compose build
docker compose up

[graphite-app]

The type reference zip.Writer should be updated to just Writer since the zip namespace declaration has been removed. This will align with the new export style used throughout the file and prevent potential type errors.

Suggested change

	writer: zip.Writer,
	writer: Writer,

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

The type references in this interface need to be updated to match the new export style. Since the zip namespace declaration has been removed, the parameter types should be changed from zip.Writer and zip.ZipWriter to just Writer and ZipWriter respectively to be consistent with the direct export approach used in the rest of the file.

Suggested change

	writer: zip.Writer,
	callback: (zipWriter: zip.ZipWriter) => void,
	writer: Writer,
	callback: (zipWriter: ZipWriter) => void,

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (a5bf591) to head (61cda5b).
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1061   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         331      331           
  Lines       10060    10060           
  Branches      926      926           
=======================================
  Hits         9277     9277           
  Misses        657      657           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Roffenlund]

I tested this again and encountered the following error when uploading a package:

2025-06-26 11:52:32.368 UTC [39] ERROR: null value in column "review_status" of relation "repository_packageversion" violates not-null constraint

There are no unapplied migrations in my development environment, and uploading a package works as expected on the master branch. A rebase onto master might resolve the issue.

[Roffenlund]

See comment: #1061 (comment)

[x753]

I tested this again and encountered the following error when uploading a package:

2025-06-26 11:52:32.368 UTC [39] ERROR: null value in column "review_status" of relation "repository_packageversion" violates not-null constraint

There are no unapplied migrations in my development environment, and uploading a package works as expected on the master branch. A rebase onto master might resolve the issue.

I rebased yesterday so that's likely unrelated. This has also happened in the past: #1112 (review)

It doesn't make sense to me that this could happen seeing as how we have a default value in the migration. Could you try running docker compose down; docker compose build; docker compose up then see if the issue persists?

If it persists, I can't recreate this, so you could test:

• Running tests to see if the same error occurs
• Migrating back to Repository 0057 then migrating forward again