Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract chip initials from display name #8492

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

marcRDZ
Copy link
Contributor

@marcRDZ marcRDZ commented Nov 4, 2024

Fixes #8381

The chip abbreviation is extracted from display name different parts splitting by special characters if present or taking two first letters simply, giving more possible combinations by default and also allowing the user customizes it through account name on general settings.

I think we should take into consideration some of the suggestions shared on this and related issues to future enhancements like add a picture option #8238 or full name below chip #8381 (comment)

@marcRDZ marcRDZ force-pushed the fix-8381_chip-abbreviation branch 2 times, most recently from b295653 to c738df6 Compare November 4, 2024 15:49
@kewisch
Copy link
Member

kewisch commented Nov 4, 2024

Thanks for taking a stab at this so quickly!

With the suggested approach I think we'll be fine for people who have e.g. multiple gmail addresses, but if I have firstname.lastname@example.com for home and firstname.lastname@thunderbird.net for work, then both would be FN if I understand correctly?

Have you seen #8381 (comment) by chance? I've since discussed this with the team and there are some concerns this could be too magical, but I'd like to work out a short term solution. Let me bring this up again tomorrow and we'll come back with a suggestion.

@marcRDZ
Copy link
Contributor Author

marcRDZ commented Nov 4, 2024

Yeah, in that case both accounts will show FL but at least the user had the chance to modify it on account settings.

Anyway, as I said it's only a practical approach. Add new features as custom pictures or other things would be really nice.

Thinking about that comment you've mentioned, if you set as default account name something different to the email address as it suggested, maybe the user realises that it can be customised clearly. In my first experience setting up accounts I didn't see that option until I'd been dealing some time with the app.

I will be looking for your suggestions, thanks!

@wmontwe
Copy link
Member

wmontwe commented Nov 5, 2024

I think using the display name is a good first step, it defaults to the users email address until it is explicitly changed. But we're discussing possible solutions and will come back to your suggestion.

@wmontwe
Copy link
Member

wmontwe commented Nov 5, 2024

Related to #8100

@marcRDZ marcRDZ force-pushed the fix-8381_chip-abbreviation branch from c738df6 to 213371d Compare November 6, 2024 12:02
@marcRDZ
Copy link
Contributor Author

marcRDZ commented Nov 6, 2024

I think using the display name is a good first step, it defaults to the users email address until it is explicitly changed. But we're discussing possible solutions and will come back to your suggestion.

I've simplified the change to this idea and I'll wait for your deliberations.

@github-actions github-actions bot added the status: answered The issue was answered and is waiting for maintainer review. label Nov 6, 2024
@wmontwe wmontwe removed the status: answered The issue was answered and is waiting for maintainer review. label Nov 6, 2024
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, we'll go with your changes and will add an additional migration step to cover existing users.

@marcRDZ
Copy link
Contributor Author

marcRDZ commented Nov 8, 2024

Great! Don't hesitate to count on me for other changes related.
There are many nice features we could add taking into account suggestions shared on this issue.

@Ted-T-east
Copy link

Below is an example of the current Android Thunderbird presentation.

Also, shown is the current Android Blue mail presentation.

Candidly, I don’t care if the underlying email account is Yahoo, Gmail, Proton, private server, etc.

But, I do wish to click on an email account directly.

Thus, it would be useful to display a user supplied two/three character identity.

How?

Add one more field to the basic account data, wherein the user can input two or three characters to more easily identify one account vs. another.

For various reasons, essentially segmentation of various “classes” of emails. I have multiple accounts. A two or three character identifier would really assist me or anyone to move directly to a target account. Showing my email accounts with a two of three character acronym identifier is far better than multiple accounts displaying YA or GM with only a color to remind server, but NOT which email account.

My email accounts and my identifying characters if the Thunderbird team would accept and implement the foregoing.

FAM     Family
FRN     Friends
VET     Veteran
PUR         Purchases
MED       Medical
NWS       Newsletters
MST       Master
MUS       Music
WFE       Wife
EVE        EVENTS

02 account mod for input
03 BlueMail
011 current and proposed

@wmontwe wmontwe merged commit 8668fab into thunderbird:main Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing name of mail account does not change the two letters in account chip.
4 participants