-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract chip initials from display name #8492
Conversation
b295653
to
c738df6
Compare
Thanks for taking a stab at this so quickly! With the suggested approach I think we'll be fine for people who have e.g. multiple gmail addresses, but if I have firstname.lastname@example.com for home and firstname.lastname@thunderbird.net for work, then both would be FN if I understand correctly? Have you seen #8381 (comment) by chance? I've since discussed this with the team and there are some concerns this could be too magical, but I'd like to work out a short term solution. Let me bring this up again tomorrow and we'll come back with a suggestion. |
Yeah, in that case both accounts will show FL but at least the user had the chance to modify it on account settings. Anyway, as I said it's only a practical approach. Add new features as custom pictures or other things would be really nice. Thinking about that comment you've mentioned, if you set as default account name something different to the email address as it suggested, maybe the user realises that it can be customised clearly. In my first experience setting up accounts I didn't see that option until I'd been dealing some time with the app. I will be looking for your suggestions, thanks! |
I think using the display name is a good first step, it defaults to the users email address until it is explicitly changed. But we're discussing possible solutions and will come back to your suggestion. |
Related to #8100 |
c738df6
to
213371d
Compare
I've simplified the change to this idea and I'll wait for your deliberations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, we'll go with your changes and will add an additional migration step to cover existing users.
Great! Don't hesitate to count on me for other changes related. |
|
Fixes #8381
The chip abbreviation is extracted from display name different parts splitting by special characters if present or taking two first letters simply, giving more possible combinations by default and also allowing the user customizes it through account name on general settings.
I think we should take into consideration some of the suggestions shared on this and related issues to future enhancements like add a picture option #8238 or full name below chip #8381 (comment)