Fix spotless being slow #8395
Merged
Fix spotless being slow #8395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
force-pushed
the
fix-spotless-being-slow
branch
from
0c73857 to
039a925
Compare
|
It looks like this introduced a problem. I now often have full builds ( I'm guessing this is because spotless gets the file listing of a directory first, then when it gets around to opening the files on that list some of them may have been deleted by another task already. Hopefully this is an easy fix because we don't want spotless to look at the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits the scope of Spotless to the module it is applied to. This greatly improves the check and formatting speed. With version 7.0.0 of Spotless the configuration cache is better supported providing an additional boost. But that is currently in beta and not included yet in this changes.
Resolves #8362