Dynamic Branding Name Support Added For Export File Name Prefix

[shamim-emon]

• Added capability of dynamic branding for export file name prefix.

Fixes #8280

[cketti]

I don't think the brand name is a good fit for this. "K-9 Mail" contains a space and some translations even localize it.

The prefix for K-9 Mail should remain "k9". The prefix for Thunderbird can be "thunderbird".

I suggest adding a FilePrefixProvider interface. For now it can live in the package com.fsck.k9.preferences.

K9AppNameProvider and TbAppNameProvider could then also implement this interface and provide the language-independent values mentioned above.

[shamim-emon]

I don't think the brand name is a good fit for this. "K-9 Mail" contains a space and some translations even localize it.

The prefix for K-9 Mail should remain "k9". The prefix for Thunderbird can be "thunderbird".

I suggest adding a FilePrefixProvider interface. For now it can live in the package com.fsck.k9.preferences.

K9AppNameProvider and TbAppNameProvider could then also implement this interface and provide the language-independent values mentioned above.

@cketti done! Please let me know if anything else needed. Thanks

[cketti]

Looks like there are only code style issues left. You can fix these by running ./gradlew spotlessApply

[shamim-emon]

Looks like there are only code style issues left. You can fix these by running ./gradlew spotlessApply

@cketti spotless issues are fixed now. Fixed the style issues with Spotless Gradle plugin(As some configuration needs to be done in my device before I could run above command from terminal and get result). Please allow the workflow execution.
In-case of failure I will do the necessary configuration and run ./gradlew spotlessApply

[shamim-emon]

Looks like there are only code style issues left. You can fix these by running ./gradlew spotlessApply

@cketti spotless issues are fixed now. Fixed the style issues with Spotless Gradle plugin(As some configuration needs to be done in my device before I could run above command from terminal and get result). Please allow the workflow execution. In-case of failure I will do the necessary configuration and run ./gradlew spotlessApply

@cketti there was an detekt linting issue that I have fixed. for future reference could you please point me to the docs/ provide list to checks I can perform locally to ensure all checks pass in CI?
Thanks

[cketti]

Thanks 👍

You can see what checks are run here:

thunderbird-android/.github/workflows/android.yml

Lines 40 to 56 in 56eaf0a

	- name: Quality - Spotless
	run: ./gradlew spotlessCheck
	- name: Quality - Detekt
	run: ./gradlew detekt
	- name: Quality - Lint
	run: ./gradlew lint
	- name: Quality - Dependency Guard
	run: ./gradlew dependencyGuard
	- name: Build
	run: ./gradlew assembleDebug
	- name: Test
	run: ./gradlew testsOnCi