Fix a crash that occurs when the password input field visibility state changes and an accessibility service is enabled running Android 7 (API level 25) and below #8071
Conversation
There was a problem hiding this comment.
Thanks for working on this ❤️
In my tests the app didn't crash on Android 8 and above. So I think this work-around can be limited to Android 7 (and below, since I wasn't able to get Talkback working in emulators prior to Android 7.1).
Unfortunately, this change currently only fixes the password input in the server settings screens. It doesn't fix the password input in the automatic account setup flow. The work-around should probably be moved further down. I think the TextFieldOutlinedPassword implementations are a good place for it.
...n/kotlin/app/k9mail/feature/account/server/settings/ui/common/ServerSettingsPasswordInput.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/app/k9mail/feature/account/server/settings/ui/common/ServerSettingsPasswordInput.kt
Outdated
Show resolved
Hide resolved
|
Ok. I will make the changes today. |
There was a problem hiding this comment.
Thanks for updating the pull request 👍
There's some code style violations. You should be able to automatically fix them using gradlew spotlessApply.
Please rewrite the history of your branch to be based on the current state of the main branch and only contains one commit with your change. This will make it easier for us to merge your change. If you need help with that, please let me know.
| * and an accessibility service is enabled. It prevents the crash by clearing and | ||
| * resetting the semantics of the composable. |
There was a problem hiding this comment.
The comment needs to be updated to reflect the new code. It should probably also include a link to the relevant Google issue: https://issuetracker.google.com/issues/348232635
muqeeta96
force-pushed
the
fix-issue-7705
branch
from
e36cad1 to
054accc
Compare
|
I mistakenly merge it. But now I fixed it with a rebase and pushed it. |
muqeeta96
changed the title
|
Thank you 👍 |
This pull request addresses a critical issue: our app crashes when the password visibility state changes while an accessibility service is enabled, particularly on devices running Android 7 (API level 25) and below. The crash stems from an interaction between accessibility services and Jetpack Compose and how these components handle accessibility events.
This issue is documented in ticket #7705, and it has also been recognized as a broader issue on Google's end, as detailed in this Google Issue Tracker.
Fixes #7705