Export identities that have no description and don't make identity descriptions unique on import #6936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identities must have an email address but all of the other fields are optional, so email address should be used to determine identity keys. Fixes thunderbird#6932
Identity descriptions don't have to be unique so they shouldn't be modified when imported to make them unique. This also means that identities with no description can be imported without giving them one (e.g. "Imported", "Imported (1)", "Imported (2)").
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identities must have an email address but all of the other fields are optional, so email address should be used to determine identity keys.
Identity descriptions don't have to be unique so they shouldn't be modified when imported to make them unique.
This also means that identities with no description can be imported without giving them one (e.g. "Imported", "Imported (1)", "Imported (2)").