Build for web and dockerfile #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
December 1, 2023 20:50
gwbischof
changed the title
added 2 commits
December 2, 2023 10:43
|
Merge please 😄 |
I'll see how to do this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets the build for web working, and adds a dockerfile to build the web image.
The Platform class which is used to check the platform it is on is not supported by web, so
kIsWebis used to check if the platform is web.See discussion on old PR: #927
I also have a github workflow to build the image on tag/release. But I think thunder-app GHCR needs to be setup first.
There are a couple things not working quite right on web still, I can fix those up in follow up PRs.
I followed the instructions here to add the sqflight binaries: https://pub.dev/packages/sqflite_common_ffi_web#setup-binaries