Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setting to show comment score rather than upvote/downvote counts #935

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Nov 30, 2023

Pull Request Description

This PR adds the ability to toggle comment scores instead of the individual upvote and downvote counts. When combined, the comment score will be orange when upvoted and blue when downvoted.

Issue Being Fixed

Issue Number: #900

Screenshots / Recordings

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-11-30.at.11.19.57.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-11-30.at.11.23.22.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu mentioned this pull request Nov 30, 2023
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjiangsu hjiangsu merged commit d315bf6 into develop Nov 30, 2023
1 check passed
@hjiangsu hjiangsu deleted the feature/combined-comment-score branch November 30, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants