-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organizing settings page and addition of post/comment previews #890
Conversation
Wow this looks awesome!!! |
@micahmo This should now be ready to go - feel free to take it for a spin and let me know if you think any settings should be moved to a different section! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I really like the reorganization and the previews.
Tiny comments:
- I liked that you replaced the ActionButtons for import/export with more standard looking settings items. I wonder if we should do the same for Apply under accessibility profiles and the Delete options under Debug.
- We had talked about having an Advanced section, but with your reorg, I don't think any single page is too overwhelming, so I think we can put this off for now.
One more thing... the post preview isn't working for me. I'll see if it's something obvious! qemu-system-x86_64_wBG3xuf5bb.mp4 |
Looks like it's because I'm not showing NFSW posts on the feed, so |
I'm not too sure how to apply the same style for accessibility profiles since it's not technically an option, but a confirmation of sorts. We can probably leave this as is for now! For debug settings, I can definitely make it match better with the rest of the settings!
Hmm, interesting, I'll take a look at this! It should still return some items as only one of them is marked as NSFW |
Alright, I've made the changes to debug page and fixed the issues with the post previews not working. Let me know if it all looks good to you now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect now!
Pull Request Description
This PR is two-fold. First, it introduces post and comment previews in the settings page. As part of this, I also took the time to reorganize some of the settings around to make it hopefully more intuitive.
Notes:
Settings -> Appearance -> Posts
andSettings -> Appearance -> Comments
respectivelyIssue Being Fixed
Issue Number: #255
I've linked an related issue here, but the implementation differs from the original issue. I would like to get more feedback on the general feel of the changed settings so feel free to comment on any aspects here.
Screenshots / Recordings
settings.mp4
Checklist
semanticLabel
s where applicable for accessibility?