Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance zoom #859

Merged
merged 13 commits into from
Jan 11, 2024
Merged

Enhance zoom #859

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b35e190
setting maximum zoom level based on image resolution
Niranjan-Dorage Oct 28, 2023
1e20f68
Merge branch 'develop' of https://github.com/Niranjan-Dorage/thunder …
Niranjan-Dorage Oct 28, 2023
aa5231a
minor changes
Niranjan-Dorage Oct 28, 2023
f43e18a
contribution info updated
Niranjan-Dorage Oct 28, 2023
772f98e
changes asked by admin done
Niranjan-Dorage Oct 28, 2023
88f2540
latest code pulled
Niranjan-Dorage Dec 29, 2023
f463061
fix: now retrieving dimentions after initstate
Niranjan-Dorage Dec 30, 2023
0f9dba0
Merge branch 'develop' into enhance_zoom
Niranjan-Dorage Jan 11, 2024
f6fd793
env file removed
Niranjan-Dorage Jan 11, 2024
47a733c
conflicts resolved
Niranjan-Dorage Jan 11, 2024
00184a8
fix: camel case added
Niranjan-Dorage Jan 11, 2024
326a8e5
minor changes
Niranjan-Dorage Jan 11, 2024
8c656af
moved changelog entry to proper version
hjiangsu Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: now retrieving dimentions after initstate
  • Loading branch information
@Niranjan-Dorage
Niranjan-Dorage committed Dec 30, 2023
commit f463061da84185d6c85f4e231864b14aa2934e34
5 changes: 3 additions & 2 deletions lib/shared/image_viewer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ class _ImageViewerState extends State<ImageViewer> with TickerProviderStateMixin
}

Future<void> getImageSize(String imageUrl, context) async {
retrieveImageDimensions(imageUrl);
Size decodedImage = await retrieveImageDimensions(imageUrl);

setState(() {
Niranjan-Dorage marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -127,7 +126,9 @@ class _ImageViewerState extends State<ImageViewer> with TickerProviderStateMixin
@override
void initState() {
super.initState();
getImageSize(widget.url!, context);
WidgetsBinding.instance.addPostFrameCallback((_) {
getImageSize(widget.url!, context);
});
}

@override
Expand Down