Oauth updates #1642
Oauth updates #1642
Conversation
gwbischof
force-pushed
the
oauth
branch
2 times, most recently
from
1c7bc51 to
1c40cb3
Compare
|
|
||
| await showBlockingInputDialog<String>( | ||
| context: context, | ||
| title: "Sign Up", |
There was a problem hiding this comment.
Remember to put these strings in the localization file!
There was a problem hiding this comment.
Which file do I update to do that?
| } else if (state.status == AuthStatus.oauthContentWarning) { | ||
| bool acceptedContentWarning = false; | ||
|
|
||
| await showThunderDialog<void>( |
There was a problem hiding this comment.
Is this code similar enough to the existing content warning code that it could be refactored into a reusable method?
| @@ -527,3 +527,78 @@ void showInputDialog<T>({ | |||
| }), | |||
| ); | |||
| } | |||
|
|
|||
| /// Shows a dialog which takes input and offers suggestions | |||
| Future<String?> showBlockingInputDialog<T>({ | |||
There was a problem hiding this comment.
This seems pretty similar to showInputDialog. Is there any way to combine these?
There was a problem hiding this comment.
showInputDialog doesn't block, so it didn't work to display the dialog where you enter your username on your first oauth login. So I modified it to create showBlockingInputDialog. So yea, they are pretty similar. I think showInputDialog is used in one other place in the code, maybe we could make that one blocking also?
Co-authored-by: William <sirwilliamthefirst@users.noreply.github.com>
Co-authored-by: William <sirwilliamthefirst@users.noreply.github.com>
…ng on getting thunderapp.dev callback working
Oauth updates.
This PR depends on thunder-app/lemmy_api_client#28
This can be tested against the lemmy instance at hopandzip.com which I deployed with the lemmy:main