Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight last tapped post #1525

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 12, 2024

Pull Request Description

This PR sort of goes along with #1520. It's a separate feature, but it's something that I realized is even more important once we have the ability to navigate out and back into posts. It introduces a small highlight color to the last selected post. This is super handy when you navigate out to check the title or media, for example, and then you want to go back into the comments. This lets you see what post you were previously looking at very easily. It's also handy when you accidentally go into a post and want to mark it as unread.

Notes

  • All of the other contents respect the read status, so it is still easy to tell whether a post is read or unread, even when it has this highlight.
  • The highlighting goes away when refreshing the feed.

This is another feature inspired by Relay, and I tried to match the implementaiton.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_sAAmZF9UIa.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu force-pushed the feature/highlight-last-tapped-post-2 branch from a5b76b8 to 6630615 Compare November 27, 2024 17:38
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just rebased this to be up to date with the latest develop branch!

@hjiangsu hjiangsu merged commit 0bcd924 into thunder-app:develop Nov 27, 2024
1 check passed
@micahmo micahmo deleted the feature/highlight-last-tapped-post-2 branch November 27, 2024 18:15
@micahmo
Copy link
Member Author

micahmo commented Nov 27, 2024

Thanks for merging this up to date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants