-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add selectable post/comment text #1327
Add selectable post/comment text #1327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few minor tweaks:
- Could we move the text actions so that the copy actions are together? We can have it in this order as an example:
- Select text
- Copy comment (renamed from copy text) to indicate that we just want to copy the whole comment. Alternatively, we could just remove this option if you feel like it might be redundant
- View original
- When we are in the bottom sheet, "Copy selected" should be disabled if the user has not selected any text to copy
It looks great. Thanks!
I think that works for now. Thanks for trying this out! |
No problem! Here's what it'll look like. qemu-system-x86_64_BeUNCWgaom.mp4This should be ready to go now! |
Pull Request Description
Alright, here's take 2 of allowing posts/comments to be selectable. This can replace #1272. Now, when choosing the option to select text, a bottom modal is displayed. There are also some quick actions for viewing raw, selecting all, and copying the selection.
P.S. I removed the checkmark related to the "View source" feature, and simply changed the text to "View original" when in source mode. This feels a little cleaner to me.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
qemu-system-x86_64_pWbytVIvG8.mp4
Checklist
semanticLabel
s where applicable for accessibility?