Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to subscribe/unsubscribe to community from long-press action #1028

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Jan 8, 2024

Pull Request Description

This PR adds the ability to subscribe/unsubscribe to communities from the long-press action on posts. Additionally, the option to block a community from the long press action only shows up on communities that you are not currently subscribed to as it does not make sense to block a community that you have subscribed to! I also did some minor refactoring.

Note that you will have to perform a manual refresh of the feed in order for the subscription indicator to refresh on the posts.

Issue Being Fixed

Issue Number: #183

Screenshots / Recordings

IMG_1567 IMG_1568

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Will the minus icon be shown if the subscription is pending? Not sure if it's a big deal, just curious.

@hjiangsu
Copy link
Member Author

Will the minus icon be shown if the subscription is pending?

Yeah it will. I'm treating the subscribed and pending statuses as nearly the same status since it doesn't really seem to affect anything at this time!

@hjiangsu hjiangsu merged commit eee21a7 into develop Jan 10, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/subscribe-community-long-press-action branch January 10, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants