Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing coverage for Multi Module Support branch #9

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ jobs:

- name: Jacoco Report to PR
id: jacoco
uses: madrapps/jacoco-report@v1.2
uses: madrapps/jacoco-report@multi-module-support
with:
paths: |
${{ github.workspace }}/app/build/reports/jacoco/prodNormalDebugCoverage/prodNormalDebugCoverage.xml,
${{ github.workspace }}/math/build/reports/jacoco/debugCoverage/debugCoverage.xml,
${{ github.workspace }}/text/build/reports/jacoco/debugCoverage/debugCoverage.xml
${{ github.workspace }}/**/build/reports/jacoco/**/prodNormalDebugCoverage.xml,
${{ github.workspace }}/**/build/reports/jacoco/**/debugCoverage.xml
token: ${{ secrets.GITHUB_TOKEN }}
min-coverage-overall: 40
min-coverage-changed-files: 60
title: Code Coverage
debug-mode: false
update-comment: true
debug-mode: true

- name: Get the Coverage info
run: |
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/java/com/madrapps/playground/MainViewModel.kt
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,8 @@ class MainViewModel : ViewModel() {
fun verifyAccess(userId: String): Boolean {
return userId == "super-admin"
}

fun verifyPassword(password: String): Boolean {
return password.isNotBlank()
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package com.madrapps.playground.events

class OnClickEvent {

fun onClick() {
// do nothing
}
}
4 changes: 4 additions & 0 deletions math/src/main/java/com/madrapps/math/Math.kt
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ class Arithmetic : MathOperation {
return a / b
}

override fun difference(a: Int, b: Int): Int {
return subtract(a, b)
}

fun modulo(a: Int, b: Int): Int {
return a % b
}
Expand Down
1 change: 1 addition & 0 deletions math/src/main/java/com/madrapps/math/MathOperation.kt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ interface MathOperation {
fun subtract(a: Int, b: Int): Int
fun multiply(a: Int, b: Int): Int
fun divide(a: Int, b: Int): Int
fun difference(a: Int, b: Int): Int

interface MathOp {

Expand Down
10 changes: 10 additions & 0 deletions math/src/main/java/com/madrapps/math/Statistics.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
@file:Suppress("unused")

package com.madrapps.math

class Statistics {

fun rateOfFlow(): Double {
return 0.1
}
}
5 changes: 5 additions & 0 deletions text/src/main/java/com/madrapps/text/StringOp.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,9 @@ public boolean endsWith(String source, String chars) {
public boolean startsWith(String source, String chars) {
return source.startsWith(chars);
}

@Override
public boolean replace(String from, String to) {
return false;
}
}
2 changes: 2 additions & 0 deletions text/src/main/java/com/madrapps/text/StringOperation.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@ public interface StringOperation {
boolean endsWith(String source, String chars);

boolean startsWith(String source, String chars);

boolean replace(String from, String to);
}
Loading