Subscription is imported as Custom Config instead of node list

[waveyl]

Operating system

Windows

System version

11

Installation type

zip

Version

1.1.1

Description

It works normally on 1.1.0-beta.3

Reproduction

Update software and use the same specific subscription

Logs

[Mahdi-zarei]

Please share a sample subscription text to reproduce it. The Reproduction field is supposed to provide a way for developers to reproduce the issue to be able to diagnose it, i certainly can't get this issue to show up by Update software and use the same specific subscription

[0-Kutya-0]

I think that's what we're talking about. Works on version 1.0.13, but does not work on version 1.1.1

sing config.txt

[parhelia512]

@Mahdi-zarei I reproduced this issue by Export Sing-box config and then Add profile from clipboard.

Throne/src/configs/sub/GroupUpdater.cpp

Line 59 in f5ffe8d

if (hasInbound && hasOutbound) return SingBoxSubType::fullConfig;

getSingBoxSubType returns SingBoxSubType::fullConfig, becuz the config jsonobject contains inbounds field.

Throne/src/configs/sub/GroupUpdater.cpp

Lines 90 to 96 in f5ffe8d

	auto subType = getSingBoxSubType(doc);
	if (subType == SingBoxSubType::fullConfig) {
	ent = Configs::ProfilesRepo::NewProfile("custom");
	ent->Custom()->type = "fullconfig";
	ent->Custom()->config = str;
	updated_order += ent;
	} else if (subType == SingBoxSubType::outboundObject) {

RawUpdater::update will deal the subscription as Custom Config.

[Mahdi-zarei]

Oh, that is actually an intended effect. Configs with inbound will be imported as full config, those without inbound or those that are only a json array of outbounds will be imported as outbounds. I think it makes sense, but i am open to suggestions.

[parhelia512]

Updating sing-box subscription does not have the same behavior as Updating v2rayn/clash subscription.
Users expect the proxies(outbounds for sing-box subscription) in subscription will be added to group by updating subscription.