Harden moving funds against edge cases #3813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszslabon
force-pushed
the
harden-moving-funds
branch
from
eb1fca6 to
ec00a89
Compare
lukasz-zimnoch
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Refs #3812.
This PR modifies the safety margin validation process used during moving funds.
It is possible that a wallet may receive deposits just before it changes states to
MovingFunds.It is also possible another wallets in
MovingFundsstate may commit to transfer their funds to it.To avoid a situation where a wallet ends up with additional funds after it has already moved their own funds we must apply a safety margin.
In #3810 we already added a 24-hour safety margin.
In this PR we add a longer 14-days safety margin when the wallet is a target of a moving funds process from another wallet. We also make sure the calculated safety margin is not greater than half of the
movingFundsTimeout, so that a wallet has enough time to finish their moving funds process.