-
Notifications
You must be signed in to change notification settings - Fork 81
Moving funds Bitcoin transaction #3767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62e8f0a
to
d2b5cc0
Compare
d3e5e8b
to
b2114a1
Compare
b2114a1
to
2acc38a
Compare
b725f71
to
0e44abe
Compare
568d517
to
69044be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some small comments and I'm happy to merge
118ac0e
to
a2e8127
Compare
lukasz-zimnoch
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Refs: #3734.
This PR introduces the creation of Bitcoin moving funds transaction which allows funds to be transferred between source wallet and target wallets.
The creation of the Bitcoin moving funds transaction is the responsibility of
movingFundsAction
which is executedafter moving funds commitment has been submitted.
Executing the
movingFundsAction
consists of several steps:32
Ethereum blocks to ensure the commitment transaction has permanently entered the blockchain and will not be removed by a chain reorganisationThe moving funds Bitcoin transaction consists of one input (main wallet UTXO of the source wallet) and one or more outputs (one output for each target wallet). The outputs are all P2WPKH.
The three moving funds transactions used in tests were actually broadcasted within the Bitcoin testnet network to get the final confirmation that the transactions were correctly contructed.