Integrate the DKG test loop with the sortition pool #3076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `beacon.Initialize` function will need to use the v2 beacon chain implementation. To not break the build, we rename the currently used implementation by adding the `V1` suffix and inject the new v2 chain implementation as the regular `beaconChain`.
the DKG executor Since `beaconchain.Interface` now exposes the `Signing` function allowing to obtain a `chain.Signing` reference, there is no point to pass it separately next to the `beaconchain.Interface` instance. This changeset cleans up that for the DKG executor code.
`ethereum.BeaconChain`
implementations from v1 chain to v2 chain handle Since `beacon.Initialize` uses the new v2 beacon chain implementation to run the DKG test loop, we need to port all stub implementations of the chain functions used by the DKG loop from the legacy v1 chain handle to the new v2 beacon chain implementation.
Member
Can we provide Hardhat task and a script for genesis? This would simplify the local development a lot. |
Member
Author
Will handle that in a separate PR! |
# Conflicts: # pkg/chain/ethereum/beacon.go
Member
Author
|
Added the Hardhat task for genesis: #3080 |
Member
|
Can we undraft this PR now given #3074 is merged? |
pdyraga
reviewed
Jul 8, 2022
# Conflicts: # cmd/start.go # pkg/beacon/beacon.go # pkg/chain/ethereum/beacon.go
.Interface` The beacon application must manage its on-chain sortition pool. That means the beacon chain interface must declare sortition-pool-specific functions. The best way to that is to embed the `sortition.Chain` interface.
pdyraga
reviewed
Jul 11, 2022
Member
|
Tested locally with 2 clients, and works as advertised! |
pdyraga
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3013
Depends on: #3074
Here we integrate the DKG test loop with the real sortition pool group selection. Apart from that, we are also integrating the new beacon chain Ethereum implementation into the beacon application code and doing some cleanup in the DKG executor API.
The following requirements must be met in order to run the client with a working DKG loop: