Skip to content

Firewall: Modified remote peer checks #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdyraga merged 29 commits into from
Jul 14, 2022
Merged

Firewall: Modified remote peer checks #3060

pdyraga merged 29 commits into from
Jul 14, 2022

Conversation

@tomaszslabon
Copy link
Contributor

@tomaszslabon tomaszslabon commented Jul 6, 2022 •
edited
Loading

This PR modifies the firewall functionalities:

  • removes anything related to stake monitor.
  • adds type anyApplicationPolicy which is used as the firewall.
    It can accept any number of applications that validate the operator's eligibility to join the network.
    If any of the applications recognizes the operator as eligible, the operator is considered successfully validated.
  • Adds IsRecognized functions to TbcChain and BeaconChain which checks whether the operator has a stake delegation.

@tomaszslabon tomaszslabon changed the title Added checks for stake delegation and minimum authorization Firewall: Added checks for stake delegation and minimum authorization Jul 6, 2022
@tomaszslabon tomaszslabon changed the title Firewall: Added checks for stake delegation and minimum authorization Firewall: Modified remote peer checks Jul 6, 2022
@tomaszslabon tomaszslabon self-assigned this Jul 6, 2022
@tomaszslabon tomaszslabon linked an issue Jul 6, 2022 that may be closed by this pull request
Update network firewall to check for non-zero stake in Threshold TokenStaking #3010
Closed
@pdyraga pdyraga mentioned this pull request Jul 6, 2022
Merged
@tomaszslabon tomaszslabon force-pushed the firewall-checks branch 5 times, most recently from cd2a9e5 to 85e8613 Compare July 7, 2022 12:12
@pdyraga pdyraga added this to the v2.0.0-m1 milestone Jul 8, 2022
@tomaszslabon tomaszslabon force-pushed the firewall-checks branch 6 times, most recently from c7fb206 to 6f59709 Compare July 11, 2022 09:11
pdyraga
pdyraga reviewed Jul 11, 2022
View reviewed changes
@tomaszslabon tomaszslabon force-pushed the firewall-checks branch 3 times, most recently from e37736a to 1f4a8b0 Compare July 11, 2022 10:26
pdyraga
pdyraga reviewed Jul 14, 2022
View reviewed changes
pdyraga
pdyraga reviewed Jul 14, 2022
View reviewed changes
@tomaszslabon
Copy link
Contributor Author

tomaszslabon commented Jul 14, 2022

Let's also enable back the firewall when starting the client:

https://github.com/keep-network/keep-core/blob/0a2b7765d1719c0fcafc821b8517e9e1755e9dc0/cmd/start.go#L85-L86

Done in 6f58c8b

@pdyraga
Copy link
Member

pdyraga commented Jul 14, 2022 •
edited
Loading

Can we also cleanup configs/config.toml.SAMPLE and delete references to all v1 contracts and instead add an entry for WalletRegistry and TokenStaking?

@tomaszslabon
Copy link
Contributor Author

tomaszslabon commented Jul 14, 2022 •
edited
Loading

Can we also cleanup configs/config.toml.SAMPLE and delete references to all v1 contracts and instead add an entry for WalletRegistry and TokenStaking?

Done in cd2144f.

@pdyraga
Copy link
Member

pdyraga commented Jul 14, 2022

Tested locally and works as advertised! 🎉

pdyraga
pdyraga previously approved these changes Jul 14, 2022
View reviewed changes
@pdyraga pdyraga merged commit 78e4d25 into main Jul 14, 2022
@pdyraga pdyraga deleted the firewall-checks branch July 14, 2022 15:26
@pdyraga pdyraga modified the milestones: v2.0.0-m0, v2.0.0-m4 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lukasz-zimnoch lukasz-zimnoch lukasz-zimnoch left review comments

@pdyraga pdyraga pdyraga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

📟 client

Projects

None yet

Milestone

v2.0.0-m1

Development

Successfully merging this pull request may close these issues.

Update network firewall to check for non-zero stake in Threshold TokenStaking

3 participants

@tomaszslabon @pdyraga @lukasz-zimnoch