GridClient Nightly ZOS3 Lite Mycelium test and update #4047

khaledyoussef24 · 2025-04-13T18:07:26Z

GridClient Nightly Replace ZOS4 VM script with ZOS3 Lite Mycelium test and update the workflow
#3927

Description

Describe the changes introduced by this PR and what does it affect

Changes

List of changes this PR includes

Related Issues

List of related issues

Tested Scenarios

A list of scenarios tried to match the deliverables

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

Preliminary Checks
- Does it completely address the issue linked?
- What about edge cases?
- Does it meet the specified acceptance criteria?
- Are there any unintended side effects?
- Does the PR adhere to the team's coding conventions, style guides, and best practices?
- Does it integrate well with existing features?
- Does it impact the overall performance of the application?
- Are there any bottlenecks or slowdowns?
- Has it been optimized for efficiency?
- Has it been adequately tested with unit, integration, and end-to-end tests?
- Are there any known defects or issues?
- Is the code well-documented?
- Are changes to documentation reflected in the code?

UI Checks:

UI Checks
- If a UI design is provided/ does it follow it?
- Does every button work?
- Is the data displayed logical? Is it what you expected?
- Does every validation work?
- Does this interface feel intuitive?
- What about slow network? Offline?
- What if the gridproxy/graphql/chain is failing?
- What would a first time user have a hard time navigating here?

Code Quality Checks:

Code Quality Checks
- Code formatted/linted? Are there unused imports? .. etc
- Is there redundant/repeated code?
- Are there conditionals that are always true or always false?
- Can we write this more concisely?
- Can we reuse this code? If yes, where?
- Will the changes be easy to maintain and update in the future?
- Can this code become too complex to understand for other devs?
- Can this code cause future integration problems?

Testing Checklist

Does it Meet the specified acceptance criteria.
Test if changes can affect any other functionality.
Tested with unit, integration, and end-to-end tests.
Tested the un-happy path and rollback scenarios.
Documentation updated to meet the latest changes.
Check automated tests working successfully with the changes.
Can be covered by automated tests.

General Checklist

…y workflow

.github/workflows/grid_client_nightly.yml

ramezsaeed · 2025-04-16T13:55:37Z

seems your latest commit failed some checks.

ramezsaeed · 2025-04-17T12:27:15Z

where is the add domain test ?

0oM4R · 2025-04-22T16:30:38Z

.github/workflows/grid_client_nightly.yml

        run: |
          yarn run ts-node --project packages/grid_client/tsconfig-node.json packages/grid_client/scripts/multiple_vms.ts

+      - name: Run test multiple vms


Suggested change

- name: Run test multiple vms

- name: Run test multiple ZOS3 lite vms

0oM4R · 2025-04-22T16:35:50Z

packages/grid_client/scripts/zos3lite_gateway_domain.ts

+
+  const gatewayOptions: FilterOptions = {
+    gateway: true,
+    availableFor: grid3.twinId,


we should add myceluim to the features

ok will add it

0oM4R

please use radnomstrings as it is failing in workflow https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/14599855602/job/40955060838

0oM4R

we already have generate random string funciton here

tfgrid-sdk-ts/packages/playground/src/utils/strings.ts

Line 20 in f241d5c

function generateString(from: string, length: number): string {

please use it

0oM4R · 2025-04-28T09:45:53Z

packages/grid_client/scripts/zos3lite_gateway_domain.ts

+  };
+
+  const gw: GatewayNameModel = {
+    name: "test",


https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/14704622210/job/41261792643 please use generate random string

0oM4R

all good now thank you

the tests are falling on qa test and main net as the files are not patched there yet can we handle that if necessary ? https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/14832340989

khaledyoussef24 · 2025-05-05T16:08:31Z

@0oM4R will check it now

khaledyoussef24 · 2025-05-06T10:07:11Z

@0oM4R checked it is failing on the other networks because it is not released yet

0oM4R

workflow should pass whenever this reached other networks

Replace ZOS4 VM script with ZOS3 Lite Mycelium test and update nightl…

8062c60

…y workflow

khaledyoussef24 requested review from 0oM4R, AhmedHanafy725, AlaaElattar, Mahmoud-Emad, MohamedElmdary, amiraabouhadid, samaradel and zaelgohary as code owners April 13, 2025 18:07

fix workflow

d3d55fd

ramezsaeed reviewed Apr 14, 2025

View reviewed changes

.github/workflows/grid_client_nightly.yml Show resolved Hide resolved

ramezsaeed mentioned this pull request Apr 14, 2025

QA progress April 2025 threefoldtech/home#1581

Closed

khaledyoussef24 added 2 commits April 14, 2025 23:26

add muliple vm for zos 3 lite scripts and nightly

6568fc9

adding multiple tests result

49c6caf

adding zos3gateway script

a70c645

0oM4R reviewed Apr 22, 2025

View reviewed changes

0oM4R requested changes Apr 22, 2025

View reviewed changes

adding domain to nightly fixing changes to make domain script work fine

ba498f0

ramezsaeed approved these changes Apr 23, 2025

View reviewed changes

khaledyoussef24 added 2 commits April 27, 2025 09:11

Fix zos3lite gateway test

c74f12b

adding random name generation to multiple vms scripts

c944899

khaledyoussef24 mentioned this pull request Apr 27, 2025

Include Liria fram in scripts and tests with alongside with freefarm #3927

Closed

khaledyoussef24 requested a review from 0oM4R April 27, 2025 17:35

0oM4R reviewed Apr 28, 2025

View reviewed changes

using the name generation from playground

83845a3

khaledyoussef24 requested a review from 0oM4R May 4, 2025 17:29

fixing genrating string functions

f636a86

0oM4R reviewed May 5, 2025

View reviewed changes

0oM4R approved these changes May 6, 2025

View reviewed changes

khaledyoussef24 merged commit 4b97c45 into development May 6, 2025
11 of 22 checks passed

khaledyoussef24 deleted the development_zos3-lite-mycelium-test branch May 6, 2025 11:18

ramezsaeed mentioned this pull request May 6, 2025

QA progress May 2025 threefoldtech/home#1583

Closed

	- name: Run test multiple vms
	- name: Run test multiple ZOS3 lite vms

GridClient Nightly ZOS3 Lite Mycelium test and update #4047

GridClient Nightly ZOS3 Lite Mycelium test and update #4047

Uh oh!

Conversation

khaledyoussef24 commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Related Issues

Tested Scenarios

Documentation PR

To consider

Preliminary Checks:

UI Checks:

Code Quality Checks:

Testing Checklist

General Checklist

Uh oh!

Uh oh!

ramezsaeed commented Apr 16, 2025

Uh oh!

ramezsaeed commented Apr 17, 2025

Uh oh!

0oM4R Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

0oM4R Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

khaledyoussef24 Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

0oM4R left a comment

Choose a reason for hiding this comment

Uh oh!

0oM4R left a comment

Choose a reason for hiding this comment

Uh oh!

0oM4R Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

0oM4R left a comment

Choose a reason for hiding this comment

Uh oh!

khaledyoussef24 commented May 5, 2025

Uh oh!

khaledyoussef24 commented May 6, 2025

Uh oh!

0oM4R left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

khaledyoussef24 commented Apr 13, 2025 •

edited

Loading