Skip to content

Texture: Introduce pmremVersion #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Methuselah96 merged 1 commit into from
Mar 23, 2024
Merged

Texture: Introduce pmremVersion #877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions types/three/src/textures/Texture.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,13 +339,6 @@ export class Texture extends EventDispatcher<{ dispose: {} }> {
*/
isRenderTargetTexture: boolean;

/**
* Indicates whether this texture should be processed by {@link THREE.PMREMGenerator} or not.
* @remarks Only relevant for render target textures.
* @defaultValue `false`
*/
needsPMREMUpdate: boolean;

/**
* An object that can be used to store custom data about the texture.
* @remarks It should not hold references to functions as these will not be cloned.
Expand All @@ -360,11 +353,24 @@ export class Texture extends EventDispatcher<{ dispose: {} }> {
*/
version: number;

/**
* Indicates whether this texture should be processed by PMREMGenerator or not (only relevant for render target
* textures)
*/
pmremVersion: number;

/**
* Set this to `true` to trigger an update next time the texture is used. Particularly important for setting the wrap mode.
*/
set needsUpdate(value: boolean);

/**
* Indicates whether this texture should be processed by {@link THREE.PMREMGenerator} or not.
* @remarks Only relevant for render target textures.
* @defaultValue `false`
*/
set needsPMREMUpdate(value: boolean);

/**
* The Global default value for {@link anisotropy | .anisotropy}.
* @defaultValue `1`.
Expand Down