fix(WebGLRenderer): physicallyCorrectLights => useLegacyLights #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…333) * Update MarchingCubes.d.ts to include missing signature for update() method * contributor
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* Add renovate.json * Update config * Prettier --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Nathan Bierema <nbierema@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update dependency prettier to v2.8.3 * Update formatting --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Nathan Bierema <nbierema@gmail.com>
* Add exports field to package.json * Add files to tsconfig.json * Add files to OTHER_FILES.txt * Remove files from tsconfig.json * Remove redundant license * Remove dependency
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
### Other changes - Make the last two parameters optional - Export a const instead of using a namespace
* check color names * prettier * recognize #hex and rgb/hsl colors * Remove broken string length constraint
* Fix usage with "module": "nodenext" * Add to OTHER_FILES
…nd BufferAttribute (#335) * chore: remove deprecated code Clean up BufferGeometry * chore: remove deprecated code Clean up some old classes * chore: add contributor * docs: correct spelling and naming * docs: update TSDocs with the lastest threeJs Documentation * style: run prettier * docs: fix lint * docs: Update TSDocs for BufferAttribute * docs: update TSDocs for BufferAttribute * docs: update TSDocs for BufferGeometry * docs: update docs links * chore: cleanUp reference not needed anymore
* docs: Update TSDoc for Clock Update TSDocs with the latest Three JS Documentation. * docs: Update TSDoc for Clock * docs: Update TSDoc for EventDispatcher * docs: Add TSDocs for UniformsGroup UniformsGroup don't have a official ThreeJS Documentation * chore: Run prettier * docs: Add TSDocs for Layers * fix: Replace param Names to the same as the Docs * docs: Add TSDocs to GLBufferAttribute * docs: Update Docs * docs: Update TSDocs for InterleavedBuffer * docs: Update TSDocs * docs: Update TSDocs * chore: Code Format * docs: Update TSDocs for InstancedBufferGeometry * docs: Update TSDocs for InstancedInterleavedBuffer * chore: Remove deprecated code * chore: Add Missing Member * docs: Update TSDocs for Uniform * chore: Remove deprecated code * docs: Update TSDocs for InstancedBufferAttribute * docs: Update TSDocs * chore: update const flag type * docs: Update TSDocs for InterleavedBufferAttribute * chore: Code Format * docs: Update TSDocs * docs: Update TSDocs for Raycaster * ocs: Update TSDocs for Object3D * docs: fix Docs Link * docs: update TSDocs for Clock Co-authored-by: 0b5vr <0b5vr@0b5vr.com> * docs: update TSDOCs for GLBufferAttribute Co-authored-by: 0b5vr <0b5vr@0b5vr.com> * docs: Update TSDoc for InterleavedBufferAttribute * docs: Update TSDocs for EventDispatcher --------- Co-authored-by: 0b5vr <0b5vr@0b5vr.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): lock file maintenance * Remove PCD Loader from OTHER_FILES See DefinitelyTyped/DefinitelyTyped#64515. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Nathan Bierema <nbierema@gmail.com>
Contributor
|
Should probably be based against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Mirrors #372 where
WebGLRenderer.physicallyCorrectLightswas renamed toWebGLRenderer.useLegacyLights, also inverted (mrdoob/three.js#24975).What
I've removed the old signature altogether, even deprecated.
Checklist
master, next goesdev)