Skip to content

Conversation

@mattrossman
Copy link
Contributor

Updates the Quaternion overloads for fromArray and toArray to align with Vector3's implementation as discussed here:
#426 (comment)

Resolves #1229

Per the CONTRIBUTING guidelines I tried to run tests after my changes (and add tests of my own) but running pnpm run test for me fails with:

> @ test /Users/matt/Code/three-ts-types
> node --require source-map-support/register node_modules/@definitelytyped/dtslint/ types/three

dtslint@0.2.23
Error: ENOENT: no such file or directory, open '/Users/matt/Code/three-ts-types/notNeededPackages.json'

I don't see a notNeededPackage.json file in the repository despite its mention in the README, so maybe these instructions or testbed are out of date. If a maintainer could provide more instruction on how to run tests I'm happy to add some test cases.

Updates the Quaternion overloads for fromArray and toArray to align with
Vector3's implementation as discussed here:
three-types#426 (comment)
@mattrossman mattrossman mentioned this pull request Sep 18, 2024
62 tasks
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure why local testing is not working, I'll try to look into that.

@Methuselah96 Methuselah96 merged commit 96db580 into three-types:master Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quaternion.fromArray() doesn't allow arbitrary length arrays

2 participants