Merged
Conversation
dmjio
reviewed
Jul 8, 2025
| => (camera, JSVal) | ||
| -> THREE.Three OrbitControls | ||
| new (cam, elt) = do | ||
| v <- jsg ("OrbitControls" :: JSString) |
Collaborator
There was a problem hiding this comment.
@juliendehos should this be THREE.OrbitControls
Contributor
Author
There was a problem hiding this comment.
In JS, we use OrbitControls like this:
import { OrbitControls } from 'three/addons/controls/OrbitControls.js';
...
const controls = new OrbitControls( camera, renderer.domElement );The PR works if we add this in the index.html:
<script type="module" >
import * as THREE from 'three';
window.THREE = THREE;
import { OrbitControls } from 'three/addons/controls/OrbitControls.js';
window.OrbitControls = OrbitControls;
</script>
dmjio
reviewed
Jul 8, 2025
| v <- jsg ("OrbitControls" :: JSString) | ||
| OrbitControls <$> J.new v (cam, elt) | ||
| ----------------------------------------------------------------------------- | ||
| update :: Method OrbitControls () Bool -- TODO () -> (Maybe Double) |
Contributor
Author
There was a problem hiding this comment.
I'm not sure how to handle optional arguments in three.hs.
The PR is a minimal integration of OrbitControls, we can update that later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OrbitControls is an addon in Three.js but I think it's important to have it in Three.hs.