Add type stubs for the sqlalchemy models #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpalmer
reviewed
May 3, 2018
| # sqlalchemy actually allows the attribute to be used for ordering like | ||
| # this; ignore the type check here specifically rather than complicate | ||
| # our type definitions. | ||
| History.id.desc(), # type: ignore |
There was a problem hiding this comment.
This feels non-ideal. Is there a way to declare the types of the fields on the type and instances separately?
There was a problem hiding this comment.
Unfortunately that doesn't seem to be possible at the moment:
from typing import ClassVar
class Thing:
class_attr: ClassVar[int] = 0
def __init__(self):
self.instance_attr: str = ""
self.class_attr: str = ''
reveal_type(Thing.class_attr)
reveal_type(Thing.instance_attr) # I'd hope this would error as not existing
t = Thing()
reveal_type(t.class_attr)
reveal_type(t.instance_attr)$ mypy thing.py
thing.py:12: error: Revealed type is 'builtins.int'
thing.py:13: error: Revealed type is 'builtins.str'
thing.py:16: error: Revealed type is 'builtins.int'
thing.py:17: error: Revealed type is 'builtins.str'
python/mypy#4886 seems to suggest there might be a solution at some point, however I don't think mypy is there yet.
|
@PeterJCLaw hope you don't mind, I've merged this. Happy to review any further changes in another PR. |
|
@danpalmer no worries; I'd actually forgotten about this PR. (I think I wasn't sure whether your comment was blocking, hence not merging it at the time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that we get real type checking for the model types, rather than the
Anychecking which we were previously getting.This currently errors due to the issue which #68 fixes (though amazingly shows no other issues), so I consider this blocked until that merges.