Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Bitstamp race condition and ANX format directive issue #342

Merged
merged 4 commits into from
Aug 26, 2019

Conversation

shazbert
Copy link
Collaborator

Description

Various bug fixes

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

go test ./... -tags=mock_test_off // for ANX

go test ./... -race -count=100 // for Bitstamp

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • [hopefully] My changes generate no new warnings
  • [n/a] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Travis with my changes
  • [n/a] Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

Copy link
Contributor

@xtda xtda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved 🙋‍♂️

@@ -20,7 +20,7 @@ func TestMain(m *testing.M) {
cfg.LoadConfig("../../testdata/configtest.json")
anxConfig, err := cfg.GetExchangeConfig("ANX")
if err != nil {
log.Fatalf("Test Failed - ANX Setup() init error", err)
log.Fatal("Test Failed - ANX Setup() init error", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 % 👀

@thrasher- thrasher- changed the title Bug fix Bugfix: Bitstamp race condition and ANX format directive issue Aug 26, 2019
@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #342 into master will not change coverage.
The diff coverage is 72.72%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   43.55%   43.55%           
=======================================
  Files         129      129           
  Lines       30991    30991           
=======================================
  Hits        13499    13499           
  Misses      16374    16374           
  Partials     1118     1118
Impacted Files Coverage Δ
exchanges/bitstamp/bitstamp.go 80.08% <72.72%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8ba0a...3c16862. Read the comment docs.

Copy link
Collaborator

@thrasher- thrasher- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks!

@thrasher- thrasher- merged commit c191dfc into thrasher-corp:master Aug 26, 2019
@shazbert shazbert deleted the bug_fix branch November 5, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants