-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LBank exchange support #327
Merged
Merged
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e274010
wip
ef5769c
Lbank support being added
fe63492
Lbank exchange linter issues fixed
aa94562
Removed the incomplete websocket stuff
705ff08
PR Requests completed
80f3077
PR request fixes
bdb61c7
Lbank Update
e5a980a
Lbank Update
9f2e2cf
Wrapper functions fixed, linter issues fixed
8ba1617
Changed as per requested in PR
8e259c6
Changed as per requested in PR
efba980
Changed as per requested in PR
e40e624
Changed as per requested in PR
3220e98
PR Requests completed
4c05759
FINALLY DONE
ae3d68c
appveyor issues fixed
e2820e3
Skip functionality for new tests
132a7de
Test functions fixed
68f459b
PR Fixes
ce5e11b
PR Fixes
fb4f325
PR Fixes
7f509e5
PR Fixes
38e9b6d
Final Changes
1e3737d
Final Changes 2
a53788f
Final Changes 3
1fb193f
Final Changes 4
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -445,3 +445,16 @@ func TestGetDepositAddress(t *testing.T) { | |
} | ||
} | ||
} | ||
|
||
func TestUpdateOrderbook(t *testing.T) { | ||
shazbert marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Every exported function in a program should have a doc comment. The first sentence should be a summary that starts with the name (TestUpdateOrderbook) being declared. |
||
a.SetDefaults() | ||
q := currency.Pair{ | ||
Delimiter: "_", | ||
Base: currency.BTC, | ||
Quote: currency.USD} | ||
|
||
_, err := a.UpdateOrderbook(q, "spot") | ||
if err != nil { | ||
t.Fatalf("Update for orderbook failed: %v", err) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,133 @@ | ||
# GoCryptoTrader package Lbank | ||
|
||
<img src="https://github.com/thrasher-corp/gocryptotrader/blob/master/web/src/assets/page-logo.png?raw=true" width="350px" height="350px" hspace="70"> | ||
|
||
|
||
[![Build Status](https://travis-ci.org/thrasher-corp/gocryptotrader.svg?branch=master)](https://travis-ci.org/thrasher-corp/gocryptotrader) | ||
[![Software License](https://img.shields.io/badge/License-MIT-orange.svg?style=flat-square)](https://github.com/thrasher-corp/gocryptotrader/blob/master/LICENSE) | ||
[![GoDoc](https://godoc.org/github.com/thrasher-corp/gocryptotrader?status.svg)](https://godoc.org/github.com/thrasher-corp/gocryptotrader/exchanges/lbank) | ||
[![Coverage Status](http://codecov.io/github/thrasher-corp/gocryptotrader/coverage.svg?branch=master)](http://codecov.io/github/thrasher-corp/gocryptotrader?branch=master) | ||
[![Go Report Card](https://goreportcard.com/badge/github.com/thrasher-corp/gocryptotrader)](https://goreportcard.com/report/github.com/thrasher-corp/gocryptotrader) | ||
|
||
|
||
This lbank package is part of the GoCryptoTrader codebase. | ||
|
||
## This is still in active development | ||
|
||
You can track ideas, planned features and what's in progresss on this Trello board: [https://trello.com/b/ZAhMhpOy/gocryptotrader](https://trello.com/b/ZAhMhpOy/gocryptotrader). | ||
|
||
Join our slack to discuss all things related to GoCryptoTrader! [GoCryptoTrader Slack](https://join.slack.com/t/gocryptotrader/shared_invite/enQtNTQ5NDAxMjA2Mjc5LTQyYjIxNGVhMWU5MDZlOGYzMmE0NTJmM2MzYWY5NGMzMmM4MzUwNTBjZTEzNjIwODM5NDcxODQwZDljMGQyNGY) | ||
|
||
## Lbank Exchange | ||
|
||
### Current Features | ||
|
||
+ REST Support | ||
|
||
### How to enable | ||
|
||
+ [Enable via configuration](https://githul.com/thrasher-corp/gocryptotrader/tree/master/config#enable-exchange-via-config-example) | ||
|
||
+ Individual package example below: | ||
|
||
```go | ||
// Exchanges will be abstracted out in further updates and examples will be | ||
// supplied then | ||
``` | ||
|
||
### How to do REST public/private calls | ||
|
||
+ If enabled via "configuration".json file the exchange will be added to the | ||
IBotExchange array in the ```go var bot Bot``` and you will only be able to use | ||
the wrapper interface functions for accessing exchange data. View routines.go | ||
for an example of integration usage with GoCryptoTrader. Rudimentary example | ||
below: | ||
|
||
main.go | ||
```go | ||
var l exchange.IBotExchange | ||
|
||
for i := range bot.exchanges { | ||
if bot.exchanges[i].GetName() == "Lbank" { | ||
l = bot.exchanges[i] | ||
} | ||
} | ||
|
||
// Public calls - wrapper functions | ||
|
||
// Fetches current ticker information | ||
tick, err := l.GetTickerPrice() | ||
if err != nil { | ||
// Handle error | ||
} | ||
|
||
// Fetches current orderbook information | ||
ob, err := l.GetOrderbookEx() | ||
if err != nil { | ||
// Handle error | ||
} | ||
|
||
// Private calls - wrapper functions - make sure your APIKEY and APISECRET are | ||
// set and AuthenticatedAPISupport is set to true | ||
|
||
// Fetches current account information | ||
accountInfo, err := l.GetAccountInfo() | ||
if err != nil { | ||
// Handle error | ||
} | ||
``` | ||
|
||
+ If enabled via individually importing package, rudimentary example below: | ||
|
||
```go | ||
// Public calls | ||
|
||
// Fetches current ticker information | ||
ticker, err := l.GetTicker() | ||
if err != nil { | ||
// Handle error | ||
} | ||
|
||
// Fetches current orderbook information | ||
ob, err := l.GetOrderBook() | ||
if err != nil { | ||
// Handle error | ||
} | ||
|
||
// Private calls - make sure your APIKEY and APISECRET are set and | ||
// AuthenticatedAPISupport is set to true | ||
|
||
// GetUserInfo returns account info | ||
accountInfo, err := l.GetUserInfo(...) | ||
if err != nil { | ||
// Handle error | ||
} | ||
|
||
// Submits an order and the exchange and returns its tradeID | ||
tradeID, err := l.Trade(...) | ||
if err != nil { | ||
// Handle error | ||
} | ||
``` | ||
|
||
### Please click GoDocs chevron above to view current GoDoc information for this package | ||
|
||
## Contribution | ||
|
||
Please feel free to submit any pull requests or suggest any desired features to be added. | ||
|
||
When submitting a PR, please abide by our coding guidelines: | ||
|
||
+ Code must adhere to the official Go [formatting](https://golang.org/doc/effective_go.html#formatting) guidelines (i.e. uses [gofmt](https://golang.org/cmd/gofmt/)). | ||
+ Code must be documented adhering to the official Go [commentary](https://golang.org/doc/effective_go.html#commentary) guidelines. | ||
+ Code must adhere to our [coding style](https://github.com/thrasher-corp/gocryptotrader/blob/master/doc/coding_style.md). | ||
+ Pull requests need to be based on and opened against the `master` branch. | ||
|
||
## Donations | ||
|
||
<img src="https://github.com/thrasher-corp/gocryptotrader/blob/master/web/src/assets/donate.png?raw=true" hspace="70"> | ||
|
||
If this framework helped you in any way, or you would like to support the developers working on it, please donate Bitcoin to: | ||
|
||
***1F5zVDgNjorJ51oGebSvNCrSAHpwGkUdDB*** | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please preserve these contributors