Binance websocket #143
Merged
Binance websocket #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work @ermalguni! Regarding commit: thrasher-@4bb2e5d This breaks Travis and people who haven't setup a custom gocryptotrader directory. It would be best to revert this. |
|
@thrasher- thanks. Will revert the commit then and update the PR. |
|
@thrasher- reverted the imports. It seems that there is still sth weird going on though. |
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
- Coverage 37.12% 36.99% -0.13%
==========================================
Files 101 102 +1
Lines 15878 15931 +53
==========================================
Hits 5894 5894
- Misses 9465 9519 +54
+ Partials 519 518 -1
Continue to review full report at Codecov.
|
|
Thanks @ermalguni! |
thrasher-
approved these changes
Jul 16, 2018
vyloy
added a commit
to vyloy/gocryptotrader
that referenced
this pull request
Jul 18, 2018
* 'master' of https://github.com/thrasher-/gocryptotrader: Fixes theme picker reference error after changes in https://github.com/thrasher-/gocryptotrader/pull/154 Improved code quality (thrasher-corp#154) Improve request package and adjust bitfinex rate limiter Bump Travis golang version Update exchange wrapper template file Binance websocket (thrasher-corp#143) Adds support for new Huobi authorised requests and a tool for ecdsa keys Use WebsocketEvent in ws client and add timestamp to Tickers Fix race condition in request Bithumb replace deprecated API to new one Improve Bithumb API error handling Add bank details support Update README.md Skip BTCC tests as REST API is not available after infrastructure update Rename GDAX -> CoinbasePro Hotfix/web dependencies (thrasher-corp#149) Fixed some typos in binance types and updated binance trading symbols in config example (thrasher-corp#148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.