Skip to content

Configure: crash when id in patch.js is wrong #218

@brliron

Description

@brliron

When the id in patch.js is wrong, thcrap_configure_v3 crashes at this line: https://github.com/thpatch/thcrap/blob/ffc4277150946c8a33695b44cd272855e47dd9b6/thcrap_configure_v3/MainWindow.xaml.cs#LL105C15-L105C15
knownPatches contains the patch names from the various repo.js files, and the id variable comes from patch_bootstrap and contains the id from patch.js. That id isn't in knownPatches, so the function knownPatches.First() throws an exception because it didn't find anything.

Something is wrong and we don't need to make things work in this case, but a readable error message would be better than a crash.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions