Fix issue where CustomSeverities are not respected in config #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original ability was added in: thoughtworks#281 When trying out the functionality, it does not respect custom_severities as documented in the README. This patch addresses it by including the porting of custom severities from the the same location where other config keys are copied I've confirmed that it works both in a new test and in manual regression testing. Fixes: thoughtworks#364
zph
force-pushed
the
zh-fix-missing-custom-severities
branch
from
86fb979 to
2efdaf2
Compare
deepthirera
approved these changes
Jun 26, 2024
deepthirera
pushed a commit
to deepthirera/talisman
that referenced
this pull request
Jul 19, 2024
…works#459) Original ability was added in: thoughtworks#281 When trying out the functionality, it does not respect custom_severities as documented in the README. This patch addresses it by including the porting of custom severities from the the same location where other config keys are copied I've confirmed that it works both in a new test and in manual regression testing. Fixes: thoughtworks#364
deepthirera
added a commit
to deepthirera/talisman
that referenced
this pull request
Jul 19, 2024
deepthirera
added a commit
that referenced
this pull request
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original ability was added in: #281
When trying out the functionality, it does not respect custom_severities as documented in the README.
This patch addresses it by including the porting of custom severities from the the same location where other config keys are copied
I've confirmed that it works both in a new test and in manual regression testing.
Fixes: #364
Side note: I didn't include further changes but it looks like golang is auto-formatting code in the project differently than what's committed in the files I touched. It's a good idea to do a single code formatting re-write so you don't have a trickle of whitespace/formatting changes in PRs.