Skip to content

Talisman broken with pre-commit because the executable is not included #432

Closed
@mpicard

Description

@mpicard

Describe the bug

When I run pre-commit run --all-files I get an error because the Talisman executable is not found. This is unconventional for a pre-commit hook. It says in the docs:

pre-commit currently supports hooks written in many languages. As long as your git repo is an installable package (gem, npm, pypi, etc.) or exposes an executable, it can be used with pre-commit.

source

Talisman is not installable with one of the supported package managers and it doesn't expose the binary because it assumes you already have it installed, which is not the way pre-commit hooks are supposed to work.

To Reproduce
Steps to reproduce the behavior:

  1. (on a new machine) install pre-commit
  2. add a .pre-commit-config.yaml with:
repos:
- repo: https://github.com/thoughtworks/talisman
   rev: v1.31.0
   hooks:
    - id: talisman-commit
  1. run pre-commit run --all-files (or commit something to trigger pre-commit)
  2. See error

Expected behavior

pre-commit works as intended and executes talisman and exit 0 (if no secrets are found) as expected behavior of pre-comimt

Screenshots

Screenshot 2023-08-02 at 17 30 58

Desktop (please complete the following information):

  • OS: MacOS Ventura

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions