-
Notifications
You must be signed in to change notification settings - Fork 2
Documentation fixes for SCAL-258631 #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ShashiSubramanya
commented
Jun 12, 2025
- getInitConfig doc update - SCAL-258631
- doc reference for actions - SCAL-251659
- link text fix in customization interface description
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
commit: |
src/embed/embedConfig.ts
Outdated
* @returns {@link EmbedConfig} The configuration embed was initialized with. | ||
* Gets the `EmbedConfig` object that was used to | ||
* initialize the SDK. You can use this method to access the | ||
* embed configuration configuration settings such as the ThoughtSpot host, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo double configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Fixed it in the new commit.
* | ||
* @example | ||
* ``` | ||
* const config = getInitConfig(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this as description for getEmbedConfig
instead of getInitConfig
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SDK docs point to this section (embedConfig.ts#L12) - https://developers.thoughtspot.com/docs/Function_getInitConfig.