Skip to content

SAML should get triggered on every button click #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SAML should get triggered on every button click #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

/**
* Enum for auth status emitted by the emitter returned from {@link init}.
* @group Authentication / Init

Check warning on line 46 in src/auth.ts

View workflow job for this annotation

GitHub Actions / build 

The type 'init' is undefined
*/
export enum AuthStatus {
/**
Expand Down Expand Up @@ -72,13 +72,13 @@
}

/**
* Event emitter returned from {@link init}.

Check warning on line 75 in src/auth.ts

View workflow job for this annotation

GitHub Actions / build 

Invalid JSDoc @Version: "SDK: 1.19.0"
* @group Authentication / Init
*/
export interface AuthEventEmitter {
/**
* Register a listener on Auth failure.
* @param event

Check warning on line 81 in src/auth.ts

View workflow job for this annotation

GitHub Actions / build 

The type 'init' is undefined
* @param listener
*/
on(event: AuthStatus.FAILURE, listener: (failureType: AuthFailureType) => void): this;
Expand Down Expand Up @@ -106,7 +106,7 @@
/**
* Remove listener from the emitter returned from init.
* @param event
* @param listener

Check warning on line 109 in src/auth.ts

View workflow job for this annotation

GitHub Actions / build 

Syntax error in type: @link AuthEvent
* @param context
* @param once
*/
Expand All @@ -125,7 +125,7 @@
export enum AuthEvent {
/**
* Manually trigger the SSO popup. This is useful when
* authStatus is SAMLRedirect/OIDCRedirect and inPopup is set to true

Check warning on line 128 in src/auth.ts

View workflow job for this annotation

GitHub Actions / build 

The type 'init' is undefined
*/
TRIGGER_SSO_POPUP = 'TRIGGER_SSO_POPUP',
}
Expand All @@ -138,7 +138,7 @@
export function getAuthEE(): EventEmitter<AuthStatus | AuthEvent> {
return authEE;
}

Check warning on line 141 in src/auth.ts

View workflow job for this annotation

GitHub Actions / build 

Missing JSDoc @returns declaration
/**
*
* @param eventEmitter
Expand All @@ -147,7 +147,7 @@
authEE = eventEmitter;
}

/**

Check warning on line 150 in src/auth.ts

View workflow job for this annotation

GitHub Actions / build 

Missing JSDoc @param "eventEmitter" description

Check warning on line 150 in src/auth.ts

View workflow job for this annotation

GitHub Actions / build 

Missing JSDoc @param "eventEmitter" type
*
*/
export function notifyAuthSDKSuccess(): void {
Expand Down Expand Up @@ -183,7 +183,7 @@
logger.error(ERROR_MESSAGE.SDK_NOT_INITIALIZED);
return;
}
authEE.emit(AuthStatus.FAILURE, failureType);

Check warning on line 186 in src/auth.ts

View workflow job for this annotation

GitHub Actions / build 

Missing JSDoc @param "failureType" description

Check warning on line 186 in src/auth.ts

View workflow job for this annotation

GitHub Actions / build 

Missing JSDoc @param "failureType" type
}

/**
Expand Down Expand Up @@ -382,7 +382,7 @@
});
});

authEE?.once(AuthEvent.TRIGGER_SSO_POPUP, openPopup);
authEE?.on(AuthEvent.TRIGGER_SSO_POPUP, openPopup);
return samlCompletionPromise;
}

Expand Down
Loading