Skip to content

Add redis engine version var #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

Conversation

brian-penguin
Copy link
Contributor

Add a new variable for configuring redis engine version
Why this change is being made:

  • New Sidekiq versions require at lease redis 7.3 to run. We have it
    hardcoded in this playbook at 6.x. I want to make it so we can change
    an env var and upgrade our Redis version

What were the changes made to support this:

  • Add a new variable to the redis-variables.tf
  • Set the default to 7.x
  • use the variable in redis.tf

Why this change is being made:
- New Sidekiq versions require at lease redis 7.3 to run. We have it
  hardcoded in this playbook at 6.x. I want to make it so we can change
  an env var and upgrade our Redis version

What were the changes made to support this:
- Add a new variable to the redis-variables.tf
- Set the default to 7.x
- use the variable in redis.tf
@brian-penguin brian-penguin requested review from clarissalimab and removed request for OlamideOl1 June 16, 2025 21:22
@brian-penguin brian-penguin self-assigned this Jun 16, 2025
@brian-penguin
Copy link
Contributor Author

@clarissalimab I've never worked with terraform directly before. Is there anything I'm missing? I am also not sure how to set the redis variable for us in the Hub application. Any advice?

@clarissalimab
Copy link
Contributor

@brian-penguin I think you got everything right!

Once we merge this and tag a version, you can go to Hub's infrastructure configuration on thoughtbot-infra, and replace the version of the terraform-flightdeck-aws-application module with the new tag and run a terraform init and push the changes to a pull request. If the terraform plan looks good, the changes will be applied once we merge your PR on thoughtbot-infra.

I would at least test running a terraform init and terraform plan against these changes before merging them, if you can. To do this, instead of replacing the module version with the new tag, you would replace it with your latest commit hash or replace the module source entirely with the relative path to your local module directory.

@brian-penguin
Copy link
Contributor Author

brian-penguin added a commit to thoughtbot/terraform-aws-databases that referenced this pull request Jun 17, 2025
Why this change is being made:
- We want to upgrade Redis for Hub. It's currently stuck on version 6
  and we want to be able to add a var to set the version
  [see terraform-flightdeck-aws-application](thoughtbot/terraform-flightdeck-aws-application#25)
  and use that for our Hub infrastructure [see
  infra](thoughtbot/thoughtbot-infra#268)

What were the changes made to support this:
- remove ignored engine_version
@brian-penguin brian-penguin merged commit cf02fbd into main Jun 23, 2025
@brian-penguin brian-penguin deleted the bt/add-redis-engine-version-var branch June 23, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants