Stub node_version more clearly in tests
#1234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Object.any_instance.stubs(:`).returns("v1.7.4\n") | ||
| actual = Suspenders::Generators::PrerequisitesGenerator.new.node_version | ||
|
|
||
| assert_match(/^1\.7\.4$/, actual) |
There was a problem hiding this comment.
@stevepolitodesign and I tried using assert_equal here, but the \n in the stub causes the test output to not show expected vs. actual if you introduce a regression.
This Slack conversation has more details.
The start-of-line ^ and end-of-line $ ensure that the regular expression isn't matching part of the string. Otherwise, assert_match(/20\.0\.0/, file) would pass if file contained 20.0.00, for example. Co-authored-by: Steve Polito <stevepolito@hey.com>
…rsion Co-authored-by: Steve Polito <stevepolito@hey.com>
louis-antonopoulos
force-pushed
the
improve-testing-of-node-version
branch
from
83097d8
to
a17f4d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
node_versionin tests in preparation for resolving Issue 1233Co-authored-by: Steve Polito stevepolito@hey.com