Scope parameters according to Rails version #989

mygulamali · 2017-01-09T17:04:47Z

Rails 5 has deprecated the keywords arguments for #permit. This patch scopes the request params according to the version of Rails.

This patch:

fixes DEPRECATION WARNING: request methods will accept only keyword arguments in future Rails versions. #867,
supercedes fix #867 by adding keyword argument params #917 such that tests associated with the changes in this PR pass,
supercedes Scope parameters according to Rails version #964 to include suggested changes from that PR,
is now based on the rails5 branch.

Thank you (again) to @freesteph for helpin' out!

houndci-bot · 2017-01-09T17:04:55Z

spec/unit/shoulda/matchers/action_controller/permit_matcher_spec.rb

@@ -502,7 +502,7 @@ def params_with_conditional_require(params, *filters)

          matcher.matches?(controller)

-          expect(context).to have_received(:patch).with(:update, {})
+          expect(context).to have_received(:patch).with(:update, expected_params)


Line is too long. [81/80]

houndci-bot · 2017-01-09T17:04:56Z

lib/shoulda/matchers/rails_shim.rb

        else
-          column.default
+          simply_generate_validation_message(attribute, type, model_name, options)


Line is too long. [82/80]

houndci-bot · 2017-01-09T17:04:56Z

lib/shoulda/matchers/rails_shim.rb

+        ::ActiveRecord::VERSION::MAJOR
+      end
+
+      def self.generate_validation_message(record, attribute, type, model_name, options)


Line is too long. [88/80]

houndci-bot · 2017-01-09T17:55:19Z

spec/unit/shoulda/matchers/action_controller/permit_matcher_spec.rb

@@ -502,7 +502,8 @@ def params_with_conditional_require(params, *filters)

          matcher.matches?(controller)

-          expect(context).to have_received(:patch).with(:update, {})
+          expect(context)
+            .to have_received(:patch).with(:update, expected_params)


Place the . on the previous line, together with the method call receiver.

houndci-bot · 2017-01-09T17:55:19Z

lib/shoulda/matchers/rails_shim.rb

+            :"errors.messages.#{type}"
+          ]
+          primary_translation_key = :"activerecord.errors.models.#{model_name}.attributes.#{attribute}.#{type}"
+          translate_options = { default: default_translation_keys }.merge(options)


Line is too long. [82/80]

houndci-bot · 2017-01-09T17:55:19Z

lib/shoulda/matchers/rails_shim.rb

+            :"errors.attributes.#{attribute}.#{type}",
+            :"errors.messages.#{type}"
+          ]
+          primary_translation_key = :"activerecord.errors.models.#{model_name}.attributes.#{attribute}.#{type}"


Line is too long. [111/80]

houndci-bot · 2017-01-09T17:55:20Z

lib/shoulda/matchers/rails_shim.rb

+            :"activerecord.errors.models.#{model_name}.#{type}",
+            :"activerecord.errors.messages.#{type}",
+            :"errors.attributes.#{attribute}.#{type}",
+            :"errors.messages.#{type}"


Put a comma after the last item of a multiline array.

houndci-bot · 2017-01-09T18:30:32Z

lib/shoulda/matchers/rails_shim.rb

+          ].join(".").to_sym
+
+          translate_options = {
+            default: default_translation_keys


Put a comma after the last item of a multiline hash.

houndci-bot · 2017-01-09T18:30:32Z

lib/shoulda/matchers/rails_shim.rb

+            "attributes",
+            attribute,
+            type,
+          ].join(".").to_sym


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2017-01-09T18:30:32Z

lib/shoulda/matchers/rails_shim.rb

+          primary_translation_key = [
+            "activerecord.errors.models",
+            model_name,
+            "attributes",


Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2017-01-09T18:30:33Z

lib/shoulda/matchers/rails_shim.rb

-        Gem::Requirement.new('>= 4.1').satisfied_by?(action_pack_version)
-      end
+          primary_translation_key = [
+            "activerecord.errors.models",


Prefer single-quoted strings when you don't need string interpolation or special symbols.

* Satisfy Rubocop * Alphabetize methods * Use `class << self` instead of `self.` so that we can privatize one of the methods

houndci-bot · 2017-09-17T21:31:59Z

lib/shoulda/matchers/rails_shim.rb

      end

-      def self.action_pack_version
-        Gem::Version.new(::ActionPack::VERSION::STRING)
+      def self.make_controller_request(context, verb, action, request_params)


Method Shoulda::Matchers::RailsShim.make_controller_request is defined at both lib/shoulda/matchers/rails_shim.rb:48 and lib/shoulda/matchers/rails_shim.rb:131.

houndci-bot · 2017-09-17T21:32:00Z

lib/shoulda/matchers/rails_shim.rb


-      def self.action_pack_gte_4_1?
-        Gem::Requirement.new('>= 4.1').satisfied_by?(action_pack_version)
+        def simply_generate_validation_message(


Method has too many lines. [18/10]

houndci-bot · 2017-09-17T21:32:00Z

lib/shoulda/matchers/rails_shim.rb

-        else
-          connection.tables
+            serialized_columns.inject({}) do |hash, column|
+              hash[column.name.to_s] = model.type_for_attribute(column.name).coder


Line is too long. [82/80]

houndci-bot · 2017-09-17T21:32:00Z

lib/shoulda/matchers/rails_shim.rb

-        translate_options = { default: default_translation_keys }.merge(options)
-        I18n.translate(primary_translation_key, translate_options)
-      end
+        def serialized_attributes_for(model)


Method has too many lines. [14/10]

houndci-bot · 2017-09-17T21:32:00Z

lib/shoulda/matchers/rails_shim.rb

+          ::ActiveRecord::VERSION::MAJOR
+        end
+
+        def generate_validation_message(


Method has too many lines. [17/10]

houndci-bot · 2017-09-17T21:36:08Z

lib/shoulda/matchers/rails_shim.rb

+
+        private
+
+        def simply_generate_validation_message(


Method has too many lines. [18/10]

houndci-bot · 2017-09-17T21:36:09Z

lib/shoulda/matchers/rails_shim.rb

+
+        private
+
+        def simply_generate_validation_message(


Method has too many lines. [18/10]

mcmire · 2017-09-17T22:00:00Z

Hey Murtaza -- thanks so much for this PR! I know it took a loooong time but your help is appreciated. 🌟

mygulamali · 2017-09-18T12:06:00Z

No worries, I appreciate that maintaining OS projects can be time consuming. Thanks for getting around to accepting this! 👍

houndci-bot reviewed Jan 9, 2017

View reviewed changes

mygulamali mentioned this pull request Jan 9, 2017

Scope parameters according to Rails version #964

Closed

houndci-bot reviewed Jan 9, 2017

View reviewed changes

guialbuk added the 🛤 Rails 5 label Apr 25, 2017

guialbuk changed the base branch from rails5 to rails-5 April 25, 2017 20:34

mcmire mentioned this pull request Jul 25, 2017

should permit failing after rails upgrade for rails 5.1.0 #1018

Closed

mcmire force-pushed the mygulamali-fix-keyword-params branch 2 times, most recently from 59a4310 to aa32915 Compare September 17, 2017 19:52

Refactor RailsShim

eec1db6

* Satisfy Rubocop * Alphabetize methods * Use `class << self` instead of `self.` so that we can privatize one of the methods

mcmire force-pushed the mygulamali-fix-keyword-params branch from aa32915 to 9cf2820 Compare September 17, 2017 21:31

houndci-bot reviewed Sep 17, 2017

View reviewed changes

Scope request parameters according to Rails version

ca761db

mcmire force-pushed the mygulamali-fix-keyword-params branch from 9cf2820 to ca761db Compare September 17, 2017 21:35

houndci-bot reviewed Sep 17, 2017

View reviewed changes

lib/shoulda/matchers/rails_shim.rb

private

def simply_generate_validation_message(

Copy link

houndci-bot Sep 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method has too many lines. [18/10]

houndci-bot reviewed Sep 17, 2017

View reviewed changes

lib/shoulda/matchers/rails_shim.rb

private

def simply_generate_validation_message(

Copy link

houndci-bot Sep 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method has too many lines. [18/10]

mcmire merged commit ca761db into rails-5 Sep 17, 2017

mcmire deleted the mygulamali-fix-keyword-params branch September 17, 2017 21:58

mcmire added this to the v4.0 milestone Sep 19, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scope parameters according to Rails version #989

Scope parameters according to Rails version #989

mygulamali commented Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Jan 9, 2017

houndci-bot Sep 17, 2017

houndci-bot Sep 17, 2017

houndci-bot Sep 17, 2017

houndci-bot Sep 17, 2017

houndci-bot Sep 17, 2017

houndci-bot Sep 17, 2017

houndci-bot Sep 17, 2017

mcmire commented Sep 17, 2017

mygulamali commented Sep 18, 2017

Scope parameters according to Rails version #989

Scope parameters according to Rails version #989

Conversation

mygulamali commented Jan 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcmire commented Sep 17, 2017

mygulamali commented Sep 18, 2017