Add array option support for have db column matcher #1465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
:array
option support forhave_db_column
matcher.Rails starting from 4.0 support array columns for postgresql and other databases.
shoulda matchers
prior to 4.5.0 just ignored so it was passible to writeexpect(...).to have_db_column(:tags).with_options(array: true)
. Check was not actually performed.shoulda-matchers
staring from 4.5.0 caused those specs to fail.