Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array option support for have db column matcher #1465

Conversation

shaggyone
Copy link
Contributor

This pull request adds :array option support for have_db_column matcher.

Rails starting from 4.0 support array columns for postgresql and other databases.

shoulda matchers prior to 4.5.0 just ignored so it was passible to write
expect(...).to have_db_column(:tags).with_options(array: true). Check was not actually performed.

shoulda-matchers staring from 4.5.0 caused those specs to fail.

@shaggyone
Copy link
Contributor Author

@mqgama could you checke the pull request, Please. I ran specs locally, I believe some kind of authorization required to run them in github actions.

@vsppedro
Copy link
Collaborator

Hi, @shaggyone, would you mind pushing the last commit again, please?

Just to check if this time the GithubActions will work properly.

Thanks!

@shaggyone
Copy link
Contributor Author

@vsppedro pushed an empty commit. Nothing seem to happen.

@vsppedro
Copy link
Collaborator

Thanks! Before, the option to approve the CI execution was not appearing. It worked!

@shaggyone
Copy link
Contributor Author

@vsppedro Great!

@vsppedro
Copy link
Collaborator

Thank you for your contribution!

@vsppedro vsppedro merged commit 629a0f0 into thoughtbot:main Dec 15, 2021
@shaggyone
Copy link
Contributor Author

@vsppedro not much, but surely useful for people, who use array columns ).

@vsppedro vsppedro mentioned this pull request Dec 22, 2021
@vsppedro vsppedro mentioned this pull request Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants