This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Fix proteus #10
Merged
Fix proteus #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,7 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.add_development_dependency "bundler", "~> 1.7" | |||
| spec.add_development_dependency "rake", "~> 10.0" | |||
| spec.add_development_dependency "rspec", "~> 2.6" | |||
| spec.add_development_dependency "rspec", "~> 3.3" | |||
There was a problem hiding this comment.
There are differences between rspec 2.x and rspec 3.x.
They recommend upgrading to rspec 2.99 first.
I assume they have been addressed...
|
Other than a couple of comments, LGTM |
| streams = STDOUT, STDERR | ||
| on_hold = streams.collect { |stream| stream.dup } | ||
| streams.each do |stream| | ||
| stream.reopen(RUBY_PLATFORM =~ /mswin/ ? 'NUL:' : '/dev/null') |
There was a problem hiding this comment.
What do you think about moving this ternary out for clarity?
There was a problem hiding this comment.
...
stream.reopen(null_stream)
...
def null_stream
if RUBY_PLATFORM =~ /mswin/
'NUL:'
else
'/dev/null'
end
endDoes this look better?
|
@elle @jyurek @tabfugnic Adjustments made and commits squashed! |
* Before all specs remove `spec/dummy` folder used for cloning the repo * Add scenario for middleman kit * it's slow because it's not being stubbed * it does everything quietly (STDOUT and STDERR are being silenced)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git ls-remote.output.[Closes #9]