This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Repository navigation
Allowing user defined Email class to be used. - #270
Merged
Merged
Conversation
houndci-bot
reviewed
Oct 31, 2016
| private | ||
|
|
||
| delegate :processor_class, :processor_method, :email_service, to: :griddler_configuration | ||
| delegate :processor_class, :email_class, :processor_method, :email_service, to: :griddler_configuration |
wingrunr21
reviewed
Feb 24, 2017
| @email_class ||= Griddler::Email | ||
| end | ||
|
|
||
| def email_class=(klass) |
Contributor
There was a problem hiding this comment.
This setter is unnecessary. This attribute should be implemented like how :processor_method and :reply_delimiter are done.
Contributor
Author
There was a problem hiding this comment.
Yeah, an attr_writer would do the trick. Want me to change it?
houndci-bot
reviewed
Feb 24, 2017
| private | ||
|
|
||
| delegate :processor_class, :processor_method, :email_service, to: :griddler_configuration | ||
| delegate :processor_class, :email_class, :processor_method, :email_service, to: :griddler_configuration |
Contributor
Author
|
@wingrunr21 it's done :) |
Contributor
|
Excellent. I'll merge and cut a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives the user more flexibility when parsing an e-mail. By default, Griddler::Email is used.