Fix upgrade from factory girl instructions #1102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2fb828b. A link to a document referred to in a tagged commit does not allow for changes and upgrades made to that particular document. Instructions are a living/breathing document that are subject to changes and improvements. I had originally wanted to improve on the upgrade instructions but could not do so readily, because they were linked to a particular tagged commit. Hence had to revert the change to allow for upgrades to be made. I have incorporated the entire changes in the linked document herein. If a link is to be made, then it must be to a document in the current head, not a fixed commit, so that changes can be readily made.
|
Thanks for your contribution! I don't think the upgrade guide belongs at the top of |
This was referenced Jun 16, 2018
|
I'm going to close this for now. Feel free to open a PR against |
|
I can add to the other branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the main proposed change?
Summary: the proposed change allows folks to easily edit instructions.
Detailed explanation: The previous commit referred the upgrade instructions to a fixed tagged commit via a link. But then how can folks upgrade or improve upon those instructions? Instructions are living/breathing documents subject to change and editing. Hence these instructions must be included in the current HEAD / commit to allow for easy emendation. That's what this commit seeks to do.
The second change
I have also edited the instructions re: upgrading. But, given the above change, you can easily emend those instructions if I've made an error :)