stubbed models which access the db inside a lock statement generate wrong error

[timdiggins]

When a stubbed model is inside a transaction it sometimes generates a difficult to decipher error.

It should give an error like:

RuntimeError: stubbed models are not allowed to access the database - Job#reload()
factory_girl-4.5.0/lib/factory_girl/strategy/stub.rb:48:in `reload'

However instead it gives an error:

ArgumentError: wrong number of arguments (1 for 0)
factory_girl-4.5.0/lib/factory_girl/strategy/stub.rb:47:in `reload'

This is because the def for reload in stub needs to include a (*args) as reload can be called with the args of the lock.

I could create a pull request for this (it's really easy) but would you welcome a PR without a spec?

[joshuaclayton]

@red56 I'd welcome a PR but please add a spec for it. I'd take a peek at https://github.com/thoughtbot/factory_girl/blob/master/spec/factory_girl/strategy/stub_spec.rb to better understand how it's being tested currently.