Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread-unsafe lazy initialization #12

Closed
wants to merge 1 commit into from
Closed

Fix thread-unsafe lazy initialization #12

wants to merge 1 commit into from

Conversation

balexand
Copy link
Contributor

The lazy initialization of env was not thread-safe. See #11 (comment).

Note that this gem is still not thread-safe when there is a chance that ENV will be accessed by other threads in an application. See #11.

@jferris
Copy link
Contributor

jferris commented Nov 24, 2014

This looks good to me. @joshuaclayton?

@joshuaclayton
Copy link
Contributor

@balexand @jferris yep, looks good; merged as 7405df9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants