Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't know how to build task 'appraisal' #120

Closed
jvenezia opened this issue Oct 12, 2016 · 3 comments
Closed

Don't know how to build task 'appraisal' #120

jvenezia opened this issue Oct 12, 2016 · 3 comments

Comments

@jvenezia
Copy link

I can't run appraisal as a rake task.

I added appraisal as a development dependency in my gemspec :
spec.add_development_dependency 'appraisal', '~> 2.1'

appraisal rake works great, but not rake appraisal.
@jvenezia
Copy link
Author

Actually it works when adding require 'appraisal' into the rakefile.

jvenezia added a commit to jvenezia/appraisal that referenced this issue Oct 12, 2016
@jvenezia
Require the appraisal to make the rake task work
455ce68 
related to thoughtbot#120
@sikachu
Copy link
Contributor

sikachu commented Oct 12, 2016

There's a chance that rake appraisal will go away pretty soon though, as we moved away from being a rake task to a command that use to run other command. So, appraisal rake would be the correct way to run it going forward and you could have the default rake task to be whatever you want.

@jvenezia
Copy link
Author

Seems ok to me :)
Thanks!

TylerRick added a commit to TylerRick/rolify that referenced this issue Jan 9, 2018
@TylerRick
Fix for: Don't know how to build task 'appraisal'
c75188c 
when running rake.

See: thoughtbot/appraisal#120
EppO pushed a commit to RolifyCommunity/rolify that referenced this issue May 11, 2018
@TylerRick @EppO
Make it safe to call Thing.with_role(:admin, user) even if user is no…
c05551d 
…t persisted (#480)

* Fix for: Don't know how to build task 'appraisal'

when running rake.

See: thoughtbot/appraisal#120

* Make it safe to call Thing.with_role(:admin, user) even if user is not persisted

This will return an empty result now (like it used to) instead of
raising an exception.

Fixes #382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sikachu @jvenezia