Add cell styles for action buttons #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosys
force-pushed
the
add-action-button-style
branch
2 times, most recently
from
cbaf340 to
6ab2dc3
Compare
goosys
commented
Mar 24, 2025
spec/example_app/app/views/admin/customers/_collection_header_actions.html.erb
Outdated
Show resolved
Hide resolved
goosys
commented
Mar 24, 2025
| @@ -42,6 +42,14 @@ button, | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| form.button_to { /* stylelint-disable selector-no-qualifying-type, selector-class-pattern */ | |||
There was a problem hiding this comment.
This is a class automatically generated by Rails' button_to, so it didn't conform to BEM rules.
goosys
force-pushed
the
add-action-button-style
branch
from
6ab2dc3 to
7caa1a4
Compare
nickcharlton
added
the
views-and-styles
This introduces a fixed with to the action buttons (edit/destroy) so that they don't get squashed by other content. It also aligns them consistently to the right, regardless of the width of the table itself.
nickcharlton
force-pushed
the
add-action-button-style
branch
from
eace050 to
3e1b9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've always been bothered by the lack of styling on action button cells (Edit/Destroy) , so I added some.
By setting a fixed
width, these cells will no longer expand or shrink unnecessarily, keeping them consistently aligned at the right end of the table.