Repository navigation
Support newer versions of REAPI - #3613
Open
peterebden wants to merge 5 commits into
Open
peterebden wants to merge 5 commits into
peterebden wants to merge 5 commits into
Conversation
toastwaffle
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not actually that much we need to do here. Overview:
On versioning: 2.1 is the minimum we truly require although there are some clarified PATH semantics in 2.3 that are somewhat relevant. They can be configured with the
remote.shellconfig property to make it work, so we shouldn't just fail a 2.1 server, and the clarification was basically codifying retroactively what servers already did in the wild anyway.Sticking with 2.1 as a minimum should avoid any issues with us upgrading internally; also AFAIK BuildGrid and JustBuild report 2.2 and 2.1 as a max version.
Also includes #3612
I probably won't land this until I'm sure current master is stable; I am pretty sure it's all safe but one thing at a time.